fix: requeue the request when the override has been changed#1097
Merged
zhiying-lin merged 2 commits intoAzure:mainfrom Mar 26, 2025
Merged
fix: requeue the request when the override has been changed#1097zhiying-lin merged 2 commits intoAzure:mainfrom
zhiying-lin merged 2 commits intoAzure:mainfrom
Conversation
zhiying-lin
force-pushed
the
fix-override-status
branch
from
8cada6d to
399c9a2
Compare
ryanzhang-oss
previously approved these changes
Mar 25, 2025
zhiying-lin
force-pushed
the
fix-override-status
branch
from
ad41969 to
124eae2
Compare
ryanzhang-oss
approved these changes
Mar 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Requeue the request when the override has been changed but the resource has not been changed.
Otherwise, the CRP will stuck in ApplyInProcess
Fixes #
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Added e2e tests
Special notes for your reviewer